Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger CI when publishing a new release #300

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Trigger CI when publishing a new release #300

merged 1 commit into from
Aug 25, 2020

Conversation

thomasperrot
Copy link
Contributor

Successful PR Checklist:

  • Tests (on my own repository)
  • Documentation
    • (not applicable?)
  • Had a good time contributing?

elemoine
elemoine reviewed Aug 25, 2020
View reviewed changes
.github/workflows/main.yml
@@ -5,8 +5,10 @@ on:
branches:
- master
tags:
- '*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want/need to keep the tags key?

Copy link
Contributor Author

@thomasperrot thomasperrot Aug 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about that. If we always use the releases to deploy new version, tags are not needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we might release with a manual tag if something broke

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say yes, we always use releases, as our workflow is to create a release from a draft release on github.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That being said, the "tags" argument didn't work :( so, not sure about that. I don't know.

@codecov
Copy link

codecov bot commented Aug 25, 2020 •
edited
Loading

Codecov Report

Merging #300 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #300   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines         1560      1560           
  Branches       164       164           
=========================================
  Hits          1560      1560

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db1a87c...bbb8345. Read the comment docs.

@ewjoachim ewjoachim merged commit 6ad7f04 into master Aug 25, 2020
@ewjoachim ewjoachim deleted the github-actions branch August 25, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elemoine elemoine elemoine left review comments

@ewjoachim ewjoachim ewjoachim approved these changes

@DainDwarf DainDwarf Awaiting requested review from DainDwarf

@mgu mgu Awaiting requested review from mgu

@pmourlanne pmourlanne Awaiting requested review from pmourlanne

@sophie-ulti sophie-ulti Awaiting requested review from sophie-ulti

Assignees
No one assigned
Labels
PR type: miscellaneous 👾 Contains misc changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasperrot @elemoine @ewjoachim