Retry on "server closed connection unexpectedly" errors #259
Conversation
elemoine
requested review from
DainDwarf,
ewjoachim,
mgu,
pmourlanne and
sophie-ulti
as code owners
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 25 25
Lines 1228 1448 +220
Branches 140 186 +46
==========================================
+ Hits 1228 1448 +220
Continue to review full report at Codecov.
|
elemoine
force-pushed
the
ele_255
branch
3 times, most recently
from
b0c1b96 to
e360db4
Compare
|
Now with tests. |
|
What does it do with a Psycopg2 sync connector ? |
You're right here to. We need to make the same sort of changes to the Psycopg2 connector. |
elemoine
force-pushed
the
ele_255
branch
2 times, most recently
from
44073c4 to
888a4af
Compare
elemoine
force-pushed
the
ele_255
branch
2 times, most recently
from
f018d3a to
161c857
Compare
|
@ewjoachim I think I took all your comments into account. But happy to have more comments if you have any :) |
| nonlocal cnt | ||
| if cnt < 2: | ||
| cnt += 1 |
There was a problem hiding this comment.
A more natural way to do this is to declare a list outside the function, and append things inside.
elemoine
force-pushed
the
ele_255
branch
3 times, most recently
from
5f5c999 to
5d970b3
Compare
procrastinate/psycopg2_connector.py
Outdated
| connection.rollback() | ||
| raise | ||
| else: | ||
| connection.commit() |
There was a problem hiding this comment.
If we put the putconn here, then we don't need the outer try anymore, no ?
There was a problem hiding this comment.
Yep, and I also need to call putconn after rollback.
Changed.
|
We're getting there \o/ Thanks for your continued efforts. |
Based on @ewjoachim's feedback.
|
I am done updating the PR. Ready for final review. |
Closes #255.
Successful PR Checklist: