Fixes 223 #224
Fixes 223 #224
Conversation
ewjoachim
requested review from
DainDwarf,
elemoine,
mgu,
pmourlanne and
sophie-ulti
as code owners
| queue: Optional[str] = None, | ||
| task: Optional[str] = None, | ||
| status: Optional[str] = None, | ||
| lock: Optional[str] = None, |
There was a problem hiding this comment.
Doesn't this one need a queueing_lock parameter as well?
There was a problem hiding this comment.
I'm not sure it makes sense... What information would you be searching if you listed queues with a queueing_lock filter ?
Happy to add it if you have a use case or if you think the lack of consistency in this aspect would be confusing.
There was a problem hiding this comment.
No it was just for the consistency with list_jobs.
| @@ -96,9 +97,9 @@ def do_retry(self, arg): | |||
|
|
|||
| Example: retry 2 | |||
| """ | |||
| print_job(self.admin.set_job_status(arg, status="todo")) | |||
| print_job(self.admin.set_job_status(arg, status="todo")) # type: ignore | |||
There was a problem hiding this comment.
Why do you need to ignore typing here?
There was a problem hiding this comment.
mypy undestands set_job_status_async but not set_job_status.
| queue: Optional[str] = None, | ||
| task: Optional[str] = None, | ||
| status: Optional[str] = None, | ||
| lock: Optional[str] = None, |
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 1097 1097
Branches 134 134
=========================================
Hits 1097 1097
Continue to review full report at Codecov.
|
Closes #223
Successful PR Checklist: