Simplify migration tests #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewjoachim
requested review from
DainDwarf,
elemoine,
mgu,
pmourlanne and
sophie-ulti
as code owners
ewjoachim
force-pushed
the
migration_tests
branch
2 times, most recently
from
6dfda45 to
18f875e
Compare
elemoine
approved these changes
May 16, 2020
ewjoachim
force-pushed
the
migration_tests
branch
from
18f875e to
e99fa4a
Compare
ewjoachim
commented
May 17, 2020
|
|
||
| env = {**os.environ, "PGSERVICEFILE": "tests/migration/pgservice.ini"} |
There was a problem hiding this comment.
@elemoine This way, we don't even need to name the fixture
There was a problem hiding this comment.
I checked with 3.6 just in case
Python 3.6.9 (default, Dec 14 2019, 18:23:02)
[GCC 4.2.1 Compatible Apple LLVM 11.0.0 (clang-1100.0.33.8)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> {**{1: 2}, 3:4}
{1: 2, 3: 4}
>>> {**{3: 2}, 3:4}
{3: 4}There was a problem hiding this comment.
I keep forgetting about this syntax. Looks good.
ewjoachim
force-pushed
the
migration_tests
branch
from
0ddb5a7 to
30257d6
Compare
|
Dammit wrong button sorry. |
elemoine
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No ticket
Ping @elemoine : Starting from your work, I simplified the process a bit. It does the same, but a bit differently. You may or may not like 100%, we can discuss any part you think is still improvable, as usual :)
Successful PR Checklist: