Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds 164 #165

Merged
merged 2 commits into from
Feb 24, 2020
Merged

Fix builds 164 #165

merged 2 commits into from
Feb 24, 2020

Conversation

ewjoachim
Copy link
Member

Cf. #164

Successful PR Checklist:

  • Tests
  • Documentation (optionally: run spell checking)
  • Had a good time contributing? (if not, feel free to give some feedback)

@codecov-io
Copy link

codecov-io commented Feb 23, 2020

Codecov Report

Merging #165 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #165   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines         848    848           
  Branches       87     87           
=====================================
  Hits          848    848

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 398eafc...13c8bca. Read the comment docs.

Copy link
Contributor

@pmourlanne pmourlanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand what's happening and how the new token fixes the issue :o Can you explain a bit more please? (sorry :/)

@ewjoachim
Copy link
Member Author

Absolutely!

In #98 / #146 , I've changed the release process to make Travis release and deploy on pypi for us. In order to do so, I've used the Travis PyPI deploy feature, but I didn't read it well enough: I tried to use a "standard" env var, but travis dosen't support env var in deploy passwords.

Because of that, the automated deployment of 0.5.0 failed.

Instead, the doc linked above explains explicitely what needs to be done: use the travis CLI tool to encrypt our token with Travis's public key, and use secure: to let travis know that they need to decrypt the token.

Another thing I noticed in the failed build is that Travis tries to deploy after each matrix element. Instead, we need to run the whole matrix and, if it worked (and if we're on master with a tag) then deploy. This can be achived with the use of build stages as described in this example

Copy link
Contributor

@pmourlanne pmourlanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your answer 👍

Makes total sense now, let's merge it 💪

Copy link
Contributor

@elemoine elemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@ewjoachim ewjoachim merged commit 816bfd5 into procrastinate-org:master Feb 24, 2020
@ewjoachim ewjoachim deleted the fix-builds-164 branch February 24, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants