-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix builds 164 #165
Fix builds 164 #165
Conversation
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 21 21
Lines 848 848
Branches 87 87
=====================================
Hits 848 848 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand what's happening and how the new token fixes the issue :o Can you explain a bit more please? (sorry :/)
Absolutely! In #98 / #146 , I've changed the release process to make Travis release and deploy on pypi for us. In order to do so, I've used the Travis PyPI deploy feature, but I didn't read it well enough: I tried to use a "standard" env var, but travis dosen't support env var in deploy passwords. Because of that, the automated deployment of 0.5.0 failed. Instead, the doc linked above explains explicitely what needs to be done: use the travis CLI tool to encrypt our token with Travis's public key, and use Another thing I noticed in the failed build is that Travis tries to deploy after each matrix element. Instead, we need to run the whole matrix and, if it worked (and if we're on master with a tag) then deploy. This can be achived with the use of build stages as described in this example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your answer 👍
Makes total sense now, let's merge it 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Cf. #164
Successful PR Checklist: