Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming Migrator as SchemaManager #161

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Renaming Migrator as SchemaManager #161

merged 1 commit into from
Feb 21, 2020

Conversation

ewjoachim
Copy link
Member

Applying a consistent wording throughout the code and the documentation

Successful PR Checklist:

  • Tests
  • Documentation (optionally: run spell checking)
  • Had a good time contributing? Ok, but not stellar

Applying a consistent wording throughout the code and the documentation
@codecov-io
Copy link

Codecov Report

Merging #161 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #161   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines         838    840    +2     
  Branches       85     85           
=====================================
+ Hits          838    840    +2
Impacted Files Coverage Δ
procrastinate/testing.py 100% <100%> (ø) ⬆️
procrastinate/app.py 100% <100%> (ø) ⬆️
procrastinate/cli.py 100% <100%> (ø) ⬆️
procrastinate/schema.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 576a84d...1e05bc5. Read the comment docs.

Copy link
Contributor

@pmourlanne pmourlanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SchemaManager sounds less like a 90s wrestling contestant but I'll allow it 🙆‍♀️

@ewjoachim ewjoachim merged commit 9ecb1d4 into master Feb 21, 2020
@ewjoachim ewjoachim deleted the create-schema branch February 21, 2020 12:50
@elemoine elemoine mentioned this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants