Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small second pass on logs #159

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Small second pass on logs #159

merged 1 commit into from
Feb 19, 2020

Conversation

ewjoachim
Copy link
Member

Cf. #102

Successful PR Checklist:

  • Tests
  • Documentation (optionally: run spell checking)
  • Had a good time contributing? (if not, feel free to give some feedback)

@codecov-io
Copy link

codecov-io commented Feb 19, 2020

Codecov Report

Merging #159 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #159   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines         833    839    +6     
  Branches       84     85    +1     
=====================================
+ Hits          833    839    +6
Impacted Files Coverage Δ
procrastinate/app.py 100% <100%> (ø) ⬆️
procrastinate/cli.py 100% <100%> (ø) ⬆️
procrastinate/worker.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2746570...4e42474. Read the comment docs.

@ewjoachim
Copy link
Member Author

In wonder if each log should be tested...

Copy link

@mgu mgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@mgu
Copy link

mgu commented Feb 19, 2020

In wonder if each log should be tested...

I wonder why no linters have seen the issues

Copy link
Contributor

@elemoine elemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise looks good to me. Thanks!

@ewjoachim ewjoachim merged commit a9f8d63 into master Feb 19, 2020
@ewjoachim ewjoachim deleted the logs branch February 19, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants