Composition postgres 142 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewjoachim
requested review from
CorBott,
DainDwarf,
elemoine,
mgu,
pmourlanne and
sophie-ulti
as code owners
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 20 21 +1
Lines 796 817 +21
Branches 79 81 +2
=====================================
+ Hits 796 817 +21
Continue to review full report at Codecov.
|
This was referenced Feb 9, 2020
ewjoachim
commented
Feb 14, 2020
elemoine
reviewed
Feb 14, 2020
procrastinate/store.py
Outdated
| @@ -13,37 +11,22 @@ def get_channel_for_queues(queues: Optional[Iterable[str]] = None) -> Iterable[s | |||
| return ["procrastinate_queue#" + queue for queue in queues] | |||
|
|
|||
|
|
|||
| class BaseJobStore: | |||
| class JobStore: | |||
| json_dumps: Optional[Callable] = None | |||
| json_loads: Optional[Callable] = None | |||
ewjoachim
commented
Feb 14, 2020
procrastinate/app.py
Outdated
|
|
||
| @property | ||
| def job_store(self) -> store.JobStore: | ||
| return store.JobStore(connector=self.connector) |
There was a problem hiding this comment.
instantiate in constructor
ewjoachim
commented
Feb 14, 2020
|
You can squash them if you want. |
ewjoachim
force-pushed
the
composition-postgres-142
branch
from
b49b216 to
5abaed4
Compare
ewjoachim
force-pushed
the
composition-postgres-142
branch
from
5abaed4 to
9683ef2
Compare
|
LGTY ? |
elemoine
reviewed
Feb 14, 2020
docs/howto/testing.rst
Outdated
| Procrastinate defines an `InMemoryJobStore` that will speed up your tests, | ||
| remove dependency to PostgreSQL and allow you to have tasks run in a | ||
| Procrastinate defines an `InMemoryConnector` that will speed up your tests, | ||
| remove dependency to PostgreSQL and allows you to have tasks run in a |
There was a problem hiding this comment.
s/allows/allow, because of will earlier in the sentence.
k4nar
approved these changes
Feb 14, 2020
elemoine
reviewed
Feb 14, 2020
| ) | ||
|
|
||
| def stop(self): | ||
| if self._connection: | ||
| interrupt_wait(connection=self._connection) |
There was a problem hiding this comment.
Did you purposefully remove stop here?
There was a problem hiding this comment.
There was a problem hiding this comment.
In that case there shouldn't be a stop method in the InMemoryConnector either, no?
elemoine
reviewed
Feb 14, 2020
procrastinate/app.py
Outdated
| @@ -51,13 +57,29 @@ def __init__( | |||
| A :py:func:`App.task` that has a custom "name" parameter, that is not | |||
| imported and whose module path is not in this list will | |||
| fail to run. | |||
| job_store: | |||
| **Deprecated**: Old name of ``connector`` | |||
There was a problem hiding this comment.
Final dot for consistency with the other docstrings.
elemoine
reviewed
Feb 14, 2020
elemoine
reviewed
Feb 14, 2020
procrastinate/aiopg_connector.py
Outdated
| connection=await self.get_connection(), socket_timeout=self.socket_timeout | ||
| # This can be called from a signal handler, better not do async stuff | ||
| def interrupt_wait(self): | ||
| if not self._connection: |
There was a problem hiding this comment.
I think we need to have if not self._connection or self._connection.closed here.
elemoine
approved these changes
Feb 14, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #142
Includes breaking changes (but I kept a compat layer and added a deprecation warning)
Successful PR Checklist: