Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a first version of dockerized development environment. #144

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

DainDwarf
Copy link
Contributor

@DainDwarf DainDwarf commented Feb 7, 2020

Closes #139

This adds a development docker environment that should let you get to it immediately.

Successful PR Checklist:

  • Tests
  • Documentation (optionally: run spell checking)
  • Had a good time contributing? (if not, feel free to give some feedback)

@DainDwarf
Copy link
Contributor Author

Still TODO:

  • Find a way to play migrations if needed, before starting the worker
  • Add documentation!

@codecov-io
Copy link

codecov-io commented Feb 7, 2020

Codecov Report

Merging #144 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #144   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines         835    835           
  Branches       85     85           
=====================================
  Hits          835    835

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 727c815...8964852. Read the comment docs.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
.dockerignore Outdated Show resolved Hide resolved
@DainDwarf DainDwarf requested a review from CorBott as a code owner February 14, 2020 13:21
@DainDwarf DainDwarf changed the title [WIP] Adding a first version of dockerized development environment. Adding a first version of dockerized development environment. Feb 14, 2020
CONTRIBUTING.rst Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@k4nar k4nar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elemoine
Copy link
Contributor

Ok, testing now…

Dockerfile Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
@DainDwarf DainDwarf force-pushed the Dockerization branch 2 times, most recently from 5ca34b4 to c2844bc Compare February 14, 2020 15:54
@elemoine
Copy link
Contributor

This is now ready for review again. As discussed with @DainDwarf and @ewjoachim I created in the CONTRIBUTING guide a section dedicated to working with Docker, the goal being to avoid clobbering the CONTRIBUTING guide with Docker-related stuff that developers not using Docker don't care about.

@elemoine elemoine force-pushed the Dockerization branch 3 times, most recently from 4471b0d to 8964852 Compare March 13, 2020 15:10
CONTRIBUTING.rst Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@elemoine elemoine merged commit 6a43c5e into master Mar 13, 2020
@elemoine elemoine deleted the Dockerization branch March 13, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerize the procrastinate development environment
5 participants