-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a first version of dockerized development environment. #144
Conversation
Still TODO:
|
f8710e2
to
41c6c4c
Compare
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 21 21
Lines 835 835
Branches 85 85
=====================================
Hits 835 835 Continue to review full report at Codecov.
|
76bf5c6
to
4c54f25
Compare
4c54f25
to
1339c1b
Compare
0b76906
to
545bce2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Ok, testing now… |
5ca34b4
to
c2844bc
Compare
This is now ready for review again. As discussed with @DainDwarf and @ewjoachim I created in the CONTRIBUTING guide a section dedicated to working with Docker, the goal being to avoid clobbering the CONTRIBUTING guide with Docker-related stuff that developers not using Docker don't care about. |
4471b0d
to
8964852
Compare
Co-authored-by: Adrien Panhaleux <[email protected]>
Closes #139
This adds a development docker environment that should let you get to it immediately.
Successful PR Checklist: