Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make two tests in test_testing async #128

Merged
merged 1 commit into from
Jan 26, 2020
Merged

Make two tests in test_testing async #128

merged 1 commit into from
Jan 26, 2020

Conversation

elemoine
Copy link
Contributor

@elemoine elemoine commented Jan 24, 2020

Use sync_wait in test_listen_for_jobs_run and test_wait_for_jobs and get rid of the "coroutine 'xxxx' was never awaited" warnings in the test output.

Make test_listen_for_jobs_run and test_wait_for_jobs async and get rid of the "coroutine 'xxxx' was never awaited" warnings in the test output.

Fixes #127.

Successful PR Checklist:

  • Tests
  • Documentation (optionally: run spell checking) Not relevant
  • Had a good time contributing? (if not, feel free to give some feedback)

@codecov-io
Copy link

codecov-io commented Jan 24, 2020

Codecov Report

Merging #128 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #128   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          19     19           
  Lines         733    733           
  Branches       70     70           
=====================================
  Hits          733    733

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d677a6...57a3b39. Read the comment docs.

Make test_listen_for_jobs_run and test_wait_for_jobs async
and get rid of the "coroutine 'xxxx' was never awaited"
warnings in the test output.
@elemoine elemoine changed the title Use sync_wait in the unit tests Make two tests in test_testing async Jan 26, 2020
@elemoine
Copy link
Contributor Author

@ewjoachim I updated my branch.

Copy link
Member

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect :)

@ewjoachim ewjoachim merged commit 18e0c42 into master Jan 26, 2020
@ewjoachim ewjoachim deleted the ele_await branch January 26, 2020 18:08
@ewjoachim ewjoachim mentioned this pull request Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Never-awaited coroutine RuntimeWarning in the unit tests
3 participants