Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A pass on the contributing doc #109

Merged
merged 3 commits into from
Nov 17, 2019
Merged

A pass on the contributing doc #109

merged 3 commits into from
Nov 17, 2019

Conversation

ewjoachim
Copy link
Member

Successful PR Checklist:

  • Documentation (optionally: run spell checking)
  • Had a good time contributing? (if not, feel free to give some feedback)

@ewjoachim
Copy link
Member Author

Ping @linoor: I've added some details to the contributing doc. In particular, I've added the which python check that cost you a bit of time. Please feel free to review.

@codecov-io
Copy link

codecov-io commented Nov 17, 2019 •
edited
Loading

Codecov Report

Merging #109 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #109   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          19     19           
  Lines         743    743           
  Branches       73     73           
=====================================
  Hits          743    743
Impacted Files Coverage Δ
procrastinate/testing.py 100% <ø> (ø) ⬆️
procrastinate/aiopg_connector.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c983e...3e59103. Read the comment docs.

pmourlanne
pmourlanne approved these changes Nov 17, 2019
View reviewed changes
Copy link
Contributor

@pmourlanne pmourlanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

mgu
mgu approved these changes Nov 17, 2019
View reviewed changes
Copy link

@mgu mgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

ewjoachim
ewjoachim commented Nov 17, 2019
View reviewed changes
CONTRIBUTING.rst Outdated Show resolved Hide resolved
@ewjoachim ewjoachim merged commit 14da087 into master Nov 17, 2019
@ewjoachim ewjoachim deleted the contrib-doc branch November 17, 2019 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmourlanne pmourlanne pmourlanne approved these changes

@mgu mgu mgu approved these changes

@CorBott CorBott Awaiting requested review from CorBott

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ewjoachim @codecov-io @mgu @pmourlanne