Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django Migrations are now created as normal files instead of being dynamically generated #1071

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

ewjoachim
Copy link
Member

Relates to #1070

This PR changes the way Django migrations are created when contributing SQL migrations to Procrastinate, from a fully dynamic & automated system to a semi-manual process. Sorry, but it's much more flexible.

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

PR label(s):

@ewjoachim ewjoachim requested a review from a team as a code owner June 6, 2024 23:10
@github-actions github-actions bot added the PR type: miscellaneous 👾 Contains misc changes label Jun 6, 2024
@ewjoachim ewjoachim enabled auto-merge June 6, 2024 23:11
@ewjoachim ewjoachim force-pushed the fix-django-migration-madness branch from a9dc1da to ff2104e Compare June 6, 2024 23:13
@ewjoachim ewjoachim force-pushed the fix-django-migration-madness branch from 40c9220 to 86a92c0 Compare June 6, 2024 23:15
Copy link

github-actions bot commented Jun 6, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  procrastinate/contrib/django
  apps.py
  static_migrations.py
Project Total  

This report was generated by python-coverage-comment-action

@ewjoachim ewjoachim merged commit 174e439 into main Jun 6, 2024
8 checks passed
@ewjoachim ewjoachim deleted the fix-django-migration-madness branch June 6, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR type: miscellaneous 👾 Contains misc changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant