Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python-coverage-comment-action failing builds #533

Closed
ewjoachim opened this issue Jan 14, 2022 · 1 comment · Fixed by #534
Closed

Python-coverage-comment-action failing builds #533

ewjoachim opened this issue Jan 14, 2022 · 1 comment · Fixed by #534
Labels
Issue appropriate for: newcomers 🤩 This issue can be safely tackled by people who never worked in this project before Issue appropriate for: Occasional contributors 😉 This issue will be best tackled by people with a minimum of experience on the project Issue appropriate for: People up for a challenge 🤯 This issue probably will be challenging to tackle Issue contains: Some GitHub Actions 🐙 Issue relates to our GitHub actions workflows

Comments

@ewjoachim
Copy link
Member

It's not very important, but somehow the "comment" workflow runs on CI events on the master branch (as evidenced by https://github.com/procrastinate-org/procrastinate/actions/runs/1697523653) even though there's a check that should skip this:

procrastinate/.github/workflows/coverage-comment.yml

Line 14 in 96577d1

${{ github.event.workflow_run.event == 'pull_request' &&

Let's investigate why and fix this.
@ewjoachim ewjoachim added Issue appropriate for: newcomers 🤩 This issue can be safely tackled by people who never worked in this project before Issue appropriate for: Occasional contributors 😉 This issue will be best tackled by people with a minimum of experience on the project Issue appropriate for: People up for a challenge 🤯 This issue probably will be challenging to tackle Issue type: Process ⚙️ Issue contains: Some GitHub Actions 🐙 Issue relates to our GitHub actions workflows labels Jan 14, 2022
ewjoachim pushed a commit that referenced this issue Jan 14, 2022
Fix #533
d28b3c7
@ewjoachim ewjoachim mentioned this issue Jan 14, 2022
Merged
4 tasks
@ewjoachim
Copy link
Member Author

I think it worked https://github.com/procrastinate-org/procrastinate/actions/runs/1697639321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue appropriate for: newcomers 🤩 This issue can be safely tackled by people who never worked in this project before Issue appropriate for: Occasional contributors 😉 This issue will be best tackled by people with a minimum of experience on the project Issue appropriate for: People up for a challenge 🤯 This issue probably will be challenging to tackle Issue contains: Some GitHub Actions 🐙 Issue relates to our GitHub actions workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #533 procrastinate-org/procrastinate
1 participant
@ewjoachim