[WIP] Fix bug in get_connection

procrastinate/aiopg_connector.py

@@ -103,7 +103,7 @@ def __init__(self, *, socket_timeout: float = store.SOCKET_TIMEOUT, **kwargs: An
         self.socket_timeout = socket_timeout
 
     async def get_connection(self, loads=None):
-        if not self._connection:
+        if not self._connection or self._connection.closed:
             self._connection = await get_connection(
                 loads=loads, **self._connection_parameters
             )

tests/integration/test_pg_store.py

@@ -525,3 +525,16 @@ async def test_close_connection_no_connection(pg_job_store):
 async def test_stop_no_connection(pg_job_store):
     pg_job_store.stop()
     # Well we didn't crash. Great.
+
+
+async def test_get_and_close_connection(pg_job_store):
+    conn1 = await pg_job_store.get_connection(loads=None)
+    assert not conn1.closed
+    conn2 = await pg_job_store.get_connection(loads=None)
+    assert conn2 is conn1
+    await pg_job_store.close_connection()
+    assert conn1.closed
+    conn2 = await pg_job_store.get_connection(loads=None)
+    assert conn2 is not conn1
+    await pg_job_store.close_connection()
+    assert conn2.closed