Skip to content

Commit

Permalink
Merge pull request #267 from peopledoc/docs-changelog
Browse files Browse the repository at this point in the history
Fix changelog script: skip draft releases
  • Loading branch information
Joachim Jablon authored Jun 23, 2020
2 parents 1dbed21 + 26f9eb3 commit 645cc40
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions docs/sphinxext/changelog.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def run(self) -> Iterable[nodes.Node]:
pypi_name = None

result_nodes: List[nodes.Node] = []
for release in releases:
for release in self.filter_releases(releases):
result_nodes.extend(
list(self.nodes_for_release(release, pypi_name=pypi_name))
)
Expand Down Expand Up @@ -73,6 +73,9 @@ def extract_pypi_package_name(self, url: str) -> str:

return stripped_url[len(prefix) :] # noqa

def filter_releases(self, releases: Iterable[Dict[str, Any]]):
yield from (release for release in releases if not release["isDraft"])

def nodes_for_release(
self, release: Dict[str, Any], pypi_name: Optional[str] = None
) -> Iterable[nodes.Node]:
Expand Down Expand Up @@ -111,7 +114,7 @@ def extract_releases(self, owner_repo: str, token: str) -> Iterable[Dict[str, An
repository(owner: "%(owner)s", name: "%(repo)s") {
releases(orderBy: {field: CREATED_AT, direction: DESC}, first:100) {
nodes {
name, descriptionHTML, url, tagName
name, descriptionHTML, url, tagName, isDraft
}
}
}
Expand Down

0 comments on commit 645cc40

Please sign in to comment.