Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Ogg Vorbis #53

Closed
Ectalite opened this issue Mar 7, 2020 · 2 comments
Closed

Support for Ogg Vorbis #53

Ectalite opened this issue Mar 7, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone
2.4.0

Comments

@Ectalite
Copy link

Ectalite commented Mar 7, 2020

Hi I saw that your library was not working with .ogg sound files. So I wanted to know if there was a chance you would support Ogg/vorbis compression.
@kevinstadler kevinstadler added the enhancement New feature or request label Mar 11, 2020
@kevinstadler
Copy link
Collaborator

kevinstadler commented Sep 6, 2023 •
edited
Loading

Going to have another look at this using some extra dependencies (cf. https://odoepner.wordpress.com/2013/07/19/play-mp3-or-ogg-using-javax-sound-sampled-mp3spi-vorbisspi/, also https://mvnrepository.com/artifact/javazoom/jlayer)

@kevinstadler kevinstadler added this to the 2.4.0 milestone Sep 6, 2023
kevinstadler added a commit that referenced this issue Sep 13, 2023
@kevinstadler
Implement mp3/ogg/.. SoundFile decoding using JavaSound
58f0eb1 
This will break Android support to some extent, but fixes #32 by
switching to the much more well-supported (and 4x faster!) mp3spi,
closes #53 by adding support via vorbisspi, and also fixes #15 since 8
bit wav files are are now simply decoded through JavaSound.
@Ectalite
Copy link
Author

Thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
2 participants
@kevinstadler @Ectalite