-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDKUpdater Improvements #713
SDKUpdater Improvements #713
Conversation
mode/tools/SDKUpdater/build.gradle
Outdated
include '**/repository-*' | ||
include '**/sdklib-*' | ||
include '**/*.jar' | ||
exclude '**/annotations-*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just take care of wat you are removing from the final fat jar. And to test it you can try android-mode as external library in an android project.
Make sure that no dependency get excluded from the final fat jar.
Thanks !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure Aditya, I started by removing the jars, and whenever I got the class not found the issue, I added those specific class jars. I made sure both the Query and Download Swing Worker tasks went well. But I will do some more testing as you suggested to make sure no necessary dependency gets excluded.
Thanks for highlighting the importance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure Aditya, I started by removing the jars, and whenever I got the class not found the issue, I added those specific class jars. I made sure both the Query and Download Swing Worker tasks went well. But I will do some more testing as you suggested to make sure no necessary dependency gets excluded.
Thanks for highlighting the importance
hey @rupeshkumar22 any update on this ?
Thanks !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ranaaditya
I am done with the testing and the updater faces no issues in fetching/installing the SDK data and reflecting back on the updater's UI. The included libraries in build.gradle are the only necessary and sufficient libraries to do the required operation of fetch or install.
Thanks
Hi @codeanticode , can you please review this PR and merge it. Thanks ! |
Better to use only |
I'm resolving Issue #718 as a part of this PR So that there won't be any PR conflict issues. |
Testing has been done from my side after applying the new changes. Also checked the updater again. Tried installing SDK with the updater. No issue has been faced. |
@rupeshkumar22 Thank you for the PR, I'm merging into a separate branch for testing before making the new release. Happy New Year :-) |
@codeanticode Happy New Year! thanks :) |
Fixes #666, #718
The PR introduces the following changes-
SDKUpdater/build.xml
Including all the jars costs 50+ MB in total for AndroidMode.zip which has been reduced to approx 32 MB.CustomProgressIndicatorToMonitor
class is being used and with the help of its overridden methods, we are able to reflect the progress on UI.An outcome of Google Summer of Code 2022
Author - Rupesh Kumar @rupeshkumar22
Mentor - Aditya Rana @ranaaditya
Project Lead(Processing For Android) - Andrés Colubri @codeanticode