Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle making a p5.Texture out of the main canvas #5815

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

davepagurek
Copy link
Contributor

Resolves #5814

Previously, if you passed the main canvas into a shader uniform, it would initially work, but would break on updates. This is because it was getting handled as an p5 HTML element rather than something p5.Graphics-like.

Changes:

  • Adds handling for a p5.Renderer
  • Adds tests to make sure resizes are handled for image, p5.Graphics, and p5.Renderer sources

PR Checklist

  • npm run lint passes
  • [Inline documentation] is included / updated
  • [Unit tests] are included / updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to resize (error thrown when canvas is resized) using p5.Graphics off-screen graphics buffer + WebGL
2 participants