Remove reference to p5 instance in p5.Vector objects #5469
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5367
Changes:
Change constructor signature called by
createVector()
ofp5.Vector
to accept_fromRadians
and_toRadians
functions as first two arguments with theirthis
value bound to the original p5 instance. This isn't changing any documented public signature so shouldn't be a breaking change.As a result, test now pass on both node 14 and node 16 because there is no longer cyclic references in p5.Vector.
PR Checklist
npm run lint
passes