Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to p5 instance in p5.Vector objects #5469

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

limzykenneth
Copy link
Member

Resolves #5367

Changes:
Change constructor signature called by createVector() of p5.Vector to accept _fromRadians and _toRadians functions as first two arguments with their this value bound to the original p5 instance. This isn't changing any documented public signature so shouldn't be a breaking change.

As a result, test now pass on both node 14 and node 16 because there is no longer cyclic references in p5.Vector.

PR Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants