Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ellipse() and arc detail bug and adding unit test to cover p5.RendererGL.prototype.ellipse and p5.RendererGL.prototype.arc #5103

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

duskvirkus
Copy link
Contributor

Resolves #5102

Changes:

  • Fixed bug for when a detail parameter of greater than 50 is passed to ellipse or arc this._renderer is undefined.
  • Changed wording on no stroke with > 50 detail warning message.
  • Updated documentation on ellipse and arc to reflect that they don't render a stroke when detail > 50.
  • Added unit tests that cover all lines of p5.RendererGL.prototype.ellipse and p5.RendererGL.prototype.arc. Something that previously was completely uncovered.

Screenshots of the change: N/A

PR Checklist

Any suggestions or modifications are very much welcome. 💕

@duskvirkus duskvirkus requested a review from stalgiag March 18, 2021 11:48
@stalgiag
Copy link
Contributor

Awesome! Thank you for the very clear and thorough PR.

@stalgiag stalgiag merged commit 4c194ec into processing:main Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ellipse() and arc() detail parameter > 50 causes error in webgl
2 participants