-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sound recording will not work in 2017 with p5.js? #1739
Comments
It seems like we will need to replace / rewrite the part of the p5.sound lib that uses the getSources, and instead use the enumerateDevices. I'm guessing that this will also need to be executed on secure origins in the future (read: HTTPS instead of HTTP) https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/enumerateDevices There could be some cross browser issues here too that I'm missing, I'm assuming from your comment that you are using chrome, can you possibly test on some other browsers too to see if you replicate the error? I'm pretty sure getSources wont work in firefox, so this might be a good fix to do anyway. |
Hi, I tested my audio webpage (using p5.js) using Firefox and Microsot Edge as well, and to my surprise, they were working - they recorded the audio and saved it, it was all perfect. Yeah, for Chrome I will need HTTPS, but I guess it's not a developer issue - it's the decision of Chrome, Firefox, etc. But from the comments left by Google at https://www.chromestatus.com/features/4765305641369600 it seems that there's consent among Chrome Firefox and Ie/Edge to cancel the support for MediaStreamTrack.getSources - so I guess the p5.js recording code will not work in either browsers very soon (Google cite an update expected in January 2017, so pretty much any moment now). I would wery much like to continue using p5.js, where/hown shoud I address or kindly ask the core developers to handle this issue, if they have the capacity to do so? Really appreciate their efforts. |
this is the place to address the 'core team' (using that term very loosely here), I'm sure lauren or others have seen this issue. Perhaps you should make a fork and have a try at it? p5 is about inclusiveness and getting everyone on board. It'd be great if you gave it a try! |
yep thanks all! I'm aware of this one and hoping to look into it very soon. :) |
Hi Guys, Boren, Lauren,
Yes You are right, and if I knew anything more about Javascript/Client side
programming other than how to insert a few, already written examples &
lines to my webpage (for every of which I know covers 1000s of lines of
real code & probably 100s of hours of dedicated work, free of charge, for
the good of the community) - I would.
But the fact is that I am simply underqualified to do so myself - that's
why I was asking if core team members maybe had the capacity to do so. I
know I can not 'request' anyone to do it for me, except that maybe they
would be doing it anyway for the whole commmunity of others who simply
don't have the knowledge (like me).
So - You are perfectly right, and I would be willing to dedicate the time,
but for me it would 1st mean learn JavaScript and in-browser programming ;)
I am very, very grateful if some of You can fix this issue and I can
continue to use p5.js for simple in-broser sound recording ;)
Thanks,
-Gergely / Hungary
2017-01-15 19:07 GMT+01:00 Lauren McCarthy <[email protected]>:
… yep thanks all! I'm aware of this one and hoping to look into it very
soon. :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1739 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AXu66Is9TS0SYR8AqlRPXBQZXIi3_wdVks5rSmB1gaJpZM4LZUqe>
.
|
fixed with processing/p5.js-sound#160, it will be in the next release of p5.sound.js |
I am very grateful, thank You very much for the fix! I hope to update my webpage ASAP. Yours, |
if you need it sooner than the next release, there's a copy here: https://github.com/processing/p5.js-sound/blob/master/lib/p5.sound.js |
Could I have ever wished for more? ;) I already start feeling ashamed for
forcing this issue to be solved instead of learning Javascript coding at a
reasonalble level myself... Will test it on all browsers and I will let You
know the results! Thanks again!
2017-01-19 3:19 GMT+01:00 Lauren McCarthy <[email protected]>:
… if you need it sooner than the next release, there's a copy here:
https://github.com/processing/p5.js-sound/blob/master/lib/p5.sound.js
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1739 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AXu66JN0RSet-OWybqfJ00pRbG-dcmx7ks5rTsgmgaJpZM4LZUqe>
.
|
My recording of the sound volume doesn´t work in chrome on PC, on my smartphone and my normal browser on my phone. So, I tryed it with this code :
|
Dear Developers,
I have been using this very nice feature of P5.js which allowed me to record sound in browsers. However, it seems some key functions will be removed in 2017.
Chrome displays the following message on the Consol, even using P5 JS Example for Recording sounds -
'MediaStreamTrack.getSources is deprecated and will be removed in M56, around January 2017. See https://www.chromestatus.com/features/4765305641369600 for more details.'
Will there be a workaround to handle this problem? If so, what and how will I have to modify in the code to work again?
Ps. It would also be great that the recording source (Primary Mic, LineIn, Optical In, Webcam Mic, Headset mic), etc, all other such sources would be easily listable-selectable for the Client and there would be a very simple example on how to let the User select the source, maybe included in the 'Recording and Saving / Playing Sound' example on P5 Js's main Examples page.
Awaiting Your kind reply, and appreciate all Your work!
-Gergely Nagy / Hungary
The text was updated successfully, but these errors were encountered: