Skip to content

Commit

Permalink
deploy .d.ts files to github release
Browse files Browse the repository at this point in the history
  • Loading branch information
Spongman committed Dec 1, 2017
1 parent 65f9e84 commit ec7d563
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tasks/release/release-github.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ module.exports = function(grunt) {
'./lib/addons/p5.sound.min.js',
'application/javascript'
],
p5ts: ['p5.d.ts', './lib/p5.d.ts', 'application/x-typescript'],
p5globalts: ['p5.global-mode.d.ts', './lib/p5.global-mode.d.ts', 'application/x-typescript'],
p5zip: ['p5.zip', './p5.zip', 'application/zip']
};

Expand Down

2 comments on commit ec7d563

@Zalastax
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it make more sense to use text/plain? Looking at https://github.com/jshttp/mime-db/tree/master/src there is no application/x-typescript, and we don't get much out of actually specifying that it's typescript. I suspect github might have problems with unknown mime types.

@Spongman
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, you're probably right. i'm not sure if github will unknown mimetypes.

Please sign in to comment.