-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Spongman
committed
Nov 30, 2017
1 parent
fa9c79a
commit e285007
Showing
2 changed files
with
8 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,6 +25,7 @@ function mod(yuidocs, localFileame, globalFilename, sourcePath) { | |
|
||
var EXTERNAL_TYPES = [ | ||
'HTMLCanvasElement', | ||
'HTMLElement', | ||
'Float32Array', | ||
'AudioParam', | ||
'AudioNode', | ||
|
@@ -273,12 +274,9 @@ function mod(yuidocs, localFileame, globalFilename, sourcePath) { | |
|
||
function generateClassConstructor(className) { | ||
var classitem = yuidocs.classes[className]; | ||
|
||
if (!classitem.is_constructor) { | ||
throw new Error(className + ' is not a constructor'); | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
Spongman
Author
Contributor
|
||
if (classitem.is_constructor) { | ||
generateClassMethod(className, classitem); | ||
} | ||
|
||
generateClassMethod(className, classitem); | ||
} | ||
|
||
function generateClassProperty(className, classitem) { | ||
|
@@ -346,6 +344,7 @@ function mod(yuidocs, localFileame, globalFilename, sourcePath) { | |
emit('// Properties from ' + className); | ||
emit.sectionBreak(); | ||
|
||
generateClassConstructor(className); | ||
generateClassProperties(className); | ||
} | ||
|
||
|
Why don't we want to throw an error any longer? I would expect us to emit some kind of warning here.