Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when deleting sketch that contains file url not on s3 #1764

Closed
catarak opened this issue Feb 16, 2021 · 1 comment · Fixed by #1765
Closed

Error when deleting sketch that contains file url not on s3 #1764

catarak opened this issue Feb 16, 2021 · 1 comment · Fixed by #1765

Comments

@catarak
Copy link
Member

catarak commented Feb 16, 2021

Nature of issue?

  • Found a bug

Details about the bug:

  • Web browser and version: N/A
  • Operating System: N/A
  • Steps to reproduce this bug:

In testing #1762, I found that the script will fail when deleting the uploaded sketches. I believe it is a bug in deleteProject.js, which doesn't check if the url is specifically an AWS S3 url!
@catarak catarak mentioned this issue Feb 16, 2021
Merged
catarak added a commit that referenced this issue Feb 16, 2021
@catarak
[#1764] Check if sketch file url is AWS S3 url
494feb6
@catarak catarak mentioned this issue Feb 16, 2021
Merged
3 tasks
catarak added a commit that referenced this issue Feb 16, 2021
@catarak
Merge pull request #1765 from processing/bug/sketch-deletion-s3
e25d803 
[#1764] Check if sketch file url is AWS S3 url
@bomanimc
Copy link
Contributor

Thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1764] Check if sketch file url is AWS S3 url processing/p5.js-web-editor
2 participants
@catarak @bomanimc