Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacement of es5 functions to es6 classes feat p5.panner #535

Merged
merged 2 commits into from
Aug 30, 2020
Merged

Replacement of es5 functions to es6 classes feat p5.panner #535

merged 2 commits into from
Aug 30, 2020

Conversation

endurance21
Copy link
Collaborator

@therewasaguy @kyle1james Please review this PR.

therewasaguy
therewasaguy approved these changes Aug 29, 2020
View reviewed changes
Copy link
Member

@therewasaguy therewasaguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tho there are merge conflicts and I think it would be good to use import anywhere the p5.Panner is used as part of this pr

@endurance21 endurance21 merged commit b6b1562 into processing:master Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therewasaguy therewasaguy therewasaguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@endurance21 @therewasaguy