replacement es5 functions to es6 classes feat p5.Oscillator #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/app.js
Outdated
| import './oscillator'; | ||
|
|
||
| import Oscillator, { SinOsc, TriOsc, SawOsc, SqrOsc } from './oscillator'; | ||
| console.log(Oscillator); |
There was a problem hiding this comment.
Suggested change
| console.log(Oscillator); |
src/oscillator.js
Outdated
| // ========================== // | ||
|
|
||
| // return sigChain(this, scale, thisChain, nextChain, Scale); | ||
| class sigChain { |
There was a problem hiding this comment.
sigChain shouldn't be a class, since we're not calling it with the new keyword, it can just remain a function
There was a problem hiding this comment.
calling a method like add that calls sigChain results in
Uncaught TypeError: Cannot call a class as a function
therewasaguy
requested changes
Aug 24, 2020
|
@therewasaguy made some changes , please have a look! |
therewasaguy
approved these changes
Aug 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@therewasaguy @kyle1james tests are smooth
need a review here ! thanks!