replacement of es5 functions to es6 classes feat p5.soundFile #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therewasaguy
approved these changes
Aug 24, 2020
| * </code></div> | ||
| */ | ||
| save(fileName) { | ||
| p5.prototype.saveSound(this, fileName, 'wav'); |
There was a problem hiding this comment.
we should import saveSound (perhaps this is handled in an upcoming PR?)
| constructor(paths, onload, onerror, whileLoading) { | ||
| if (typeof paths !== 'undefined') { | ||
| if (typeof paths === 'string' || typeof paths[0] === 'string') { | ||
| var path = p5.prototype._checkFileFormats(paths); |
There was a problem hiding this comment.
something for the backlog: we should probably import checkFileFormats and remove it from the p5 prototype
There was a problem hiding this comment.
looks like we've started taking care of this in #540, fantastic!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all test working fine !
@therewasaguy @kyle1james please review this pr!