replacement of es5 functions to es6 class def feat.P5.FFT

[endurance21]

area covered
src/fft.js

[therewasaguy]

rather than use .prototype, we can place these methods within the class, similar to the constructor method (which should be at the top), like

class FFT {
...
  setInput(source) {
   ...
  }
}

[endurance21]

and yes for sure , we can do so , but a Big BUT is that ,
declaring the method this way , significantly helps in memory optimizations !
as we can see here
https://www.thecodeship.com/web-development/methods-within-constructor-vs-prototype-in-javascript/

should we consider those memory optimization techniques ! ?

[LilaShiba]

Great point to bring up and I'm looking forward to hearing more! Do the con's of memory outweigh the pros of having access to vars inside the constructor?

https://stackoverflow.com/questions/4508313/advantages-of-using-prototype-vs-defining-methods-straight-in-the-constructor

[therewasaguy]

These links are from before ES6.

It's true that we don't want to define the method within the constructor.

To clarify: I'm suggesting that we define it next to / after the constructor, as part of the class. This is syntactic sugar for adding the method to the prototype.

class FFT {
  constructor() { ... }
  setInput(source) { ... }
}

[endurance21]

@therewasaguy wow! i just confirmed it , i made a class and tested it .prototype and its object proto and wolla !
i saw , method was present in there in its prototype object !
That was a nice concept ! i

[LilaShiba]

That syntactical sugar will get you every time.

[endurance21]

@kyle1james ohk ohk

[therewasaguy]

Looks to be off to a good start! Just a small comment

[endurance21]

@therewasaguy @kyle1james require your review !

[LilaShiba]

The only silly comment I have is if we want to use var or let/const to keep with ES6? Perhaps this is a separate issue to flag for later? Awesome job btw and love your quick turn arounds! 😄

[endurance21]

@Kyle1james Yes that is for later prs 😇
I think its ready to merge now 🙃

[therewasaguy]

Looks good! Just one comment on another es6 class feature we could use, whether in this or or a follow-up