fetching latest p5.js code from npm #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therewasaguy
reviewed
Jul 9, 2020
There was a problem hiding this comment.
Thanks for working on this, @endurance21 !
I'm wondering if we should re-add p5.js (and p5.min.js) to the git repo as part of this PR? They were removed in #483.
I'd prefer to figure out how to avoid checking those files into the repo and to just let npm install those files when we need them:
- for local development (which this PR handles 🎉 )
- for automated testing (I believe we're also covered by the post-install script here?)
- and for gh-pages (this one I'm not sure about)
We could look at gh-pages as a separate ticket if you'd prefer to focus on the install script with this PR. We could use a library like this https://www.npmjs.com/package/gh-pages to publish just what we need to the gh-pages branch, without checking it into the main branch. For this PR, I'd say either add both files (p5.js and p5.min.js), or don't add either of them.
LilaShiba
reviewed
Jul 13, 2020
* modifications in postinstall script * removed p5.js file
|
@therewasaguy @kyle1james it's good to go now ! |
therewasaguy
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#484
some highlights
installing latest p5 from npm version "1.0.0"
post-install Scripts :