Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pre-commit hook #492

Merged
merged 11 commits into from
May 17, 2020
Merged

added pre-commit hook #492

merged 11 commits into from
May 17, 2020

Conversation

endurance21
Copy link
Collaborator

added pre-commit hooks!

HIGHLIGHTS!

  • used grunt-githooks as dev dependency!
  • added postinstall script in order to bind the lint to pre-commit hooks of git

eslint and prettier: lint everything
@LilaShiba
Copy link
Collaborator

Feature branch is behind master. I'll wait for us all to chat to figure out our best workflow. Awesome to see git hooks!

@LilaShiba
Copy link
Collaborator

Cool beans, rebased with master

Copy link
Collaborator

@LilaShiba LilaShiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 I rebased with master and loved seeing eslint run as I commited!

@LilaShiba LilaShiba merged commit 15a87b6 into master May 17, 2020
@montoyamoraga montoyamoraga deleted the githooks branch May 17, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants