initial replacements of module system

[endurance21]

This Pr is under the purview of GSOC'20 project

• all native require and module.exports of nodejs has been changed to es6 export and import in src folder !

[LilaShiba]

See notes here https://pf-gsoc.slack.com/archives/C013F4XKRK4/p1589824958001200

[endurance21]

i have added p5.js file for the sole purpose of testing the APIs !

[endurance21]

@therewasaguy @kyle1james
fixed the bug of setting the context of tone.js explicitly!
looking forward for your reviews !

[LilaShiba]

There are two conflicting files, which should be a quick fix. The PR highlights those for you. I'm having trouble verifying a PR due to lack of tests in place. So, I'd wait for Jason to give that ole 👍

[therewasaguy]

@endurance21 can you highlight any changes you've made to the src files, aside from changing import/exports? It's hard to know what the diffs are since the indentation of every file changes now that we're not wrapping everything in a define function.

• The compiled lib/p5.sound.js seems to have shrunk significantly. Have you rebuilt it with the latest changes? In the future, it would be easier to review the changes to src/ files separately from the compiled library.

• The Tone API has changed, and instead of a TimelineSignal, we're now importing the TransportTimelineSignal. This signal is very similar to the Web Audio API's AudioParam https://developer.mozilla.org/en-US/docs/Web/API/AudioParam, but it enables us to getValueAtTime which is not part of the web audio API spec. It is used in p5.Envelope and p5.PolySynth. And, in order to use it, we need to "start" the Tone Transport.. We can do this with

import Transport from 'Tone/core/Transport';
Transport.start();

[endurance21]

@therewasaguy i have made the requested changes and resolved the merge conflict too !
looking forward for the merge !

[therewasaguy]

it looks like oscillator has not been updated, and it's throwing some errors when testing locally.

also, be sure to either update the compiled library, or exclude it from the PR/commits

[endurance21]

it looks like oscillator has not been updated, and it's throwing some errors when testing locally.

also, be sure to either update the compiled library, or exclude it from the PR/commits

added the oscillator updates !

[endurance21]

There are two conflicting files, which should be a quick fix. The PR highlights those for you. I'm having trouble verifying a PR due to lack of tests in place. So, I'd wait for Jason to give that ole

done !

[endurance21]

@therewasaguy i have not pushed the latest build file so , while you are running tests locally using my latest commit , make sure to build it once !

[therewasaguy]

This is looking good!

I would love to see it go a step further to ensure consistency with how we export and import modules, as mentioned here, but that doesn’t need to happen as part of this PR.

Just remove a comment, rebuild (or remove the builds), and we can merge.

[therewasaguy]

Hey @endurance21 sorry I was unclear about this in my previous comment, but currently, there's a commit that adds “deletes” for the /lib files to the commit history. I don’t think we want that, but rather to remove the modifications to those files from the commit history. Something like this...

Or, it's probably easier just to include the compiled lib in this PR, if you want to add it back :)

[endurance21]

@therewasaguy also there was p5. Js file added in that folder only for testing purpose,

So finally i think i have to do is

1.remove the p5. Js file from lib
2.build using grunt and commit those build file
??

[therewasaguy]

yes, that sounds good @endurance21

[endurance21]

@therewasaguy i have added build files , take a look at that !

[therewasaguy]

great work, @endurance21. Let's ✅ this massive PR!

[LilaShiba]

🎉

[therewasaguy]

@endurance21 feel free to "squash-and-merge"