added unit test for p5.gain in es6

[endurance21]

added unit tests for all the methods in p5.Gain
here are the test results and AUDIO GRAPH ( inspected with WEB AUDIO INSPECTOR) of this unit test

[endurance21]

@therewasaguy
please review this PR !
Also, i have been using this amazing WEB AUDIO INSPECTOR tool to see the AUDIO GRAPHS
, I find it very useful while working with web audio API, i am curious if we can use this as integrated part of our codebase, it will really help the developers to understand and write codes ,specially when they can see what they are creating!

[endurance21]

@therewasaguy we can add it too?

[therewasaguy]

looks good just a couple questions

[therewasaguy]

this is testing that we are able to call the disconnect method without that throwing any runtime errors, but how do we know if we successfully disconnected? (I'm not sure!)

Also, will this disconnect the inputNode or only the connection between the mainGaneNode and the outputNode? I think it's only that one. Again, how would we know from this test?

[Abhijay007]

Seems like the Test for p5.Gain.js is already updated and present in the repo, refer: https://github.com/processing/p5.js-sound/blob/main/test/tests/p5.Gain.js (last updated by @satyasaibhushan) ,

@davepagurek I think we can close this PR now.

[davepagurek]

We may want to copy over just the can set the output level of gain Node test, since the current test file doesn't test changing the gain at all. But I think that's the only one that isn't covered now!

[Abhijay007]

We may want to copy over just the can set the output level of gain Node test, since the current test file doesn't test changing the gain at all. But I think that's the only one that isn't covered now!

okay got it, so can I open a PR to add the can set the output level of gain Node in the existing gain test?

[davepagurek]

yeah sounds good!

[Abhijay007]

Okay will do !!

…

On Wed, 4 Jan 2023, 02:58 Dave Pagurek, ***@***.***> wrote: yeah sounds good! — Reply to this email directly, view it on GitHub <#462 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APLHP3SE6DY7RHRQ4HWY4XDWQSKXTANCNFSM4MWPXVDA> . You are receiving this because you commented.Message ID: <processing/p5. ***@***.***>

[davepagurek]

Thanks @Abhijay007! I'll close this PR and carry over reviews on your new one.