Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following up on #283
This pulls in Yotam Mann's StartAudioContext.
I got a bit sidetracked looking at his new library UnmuteButton which would be another very cool solution. But it would involve upgrading to Tone 13.2, and shimming the unmute library (which uses
class
) to es5 or making p5.sound es6 friendly. If anyone wants to take this on that would be amazing.In the meantime, this PR:
userStartAudio
methodTo test:
--disable-features
flags, i.e.Here's a little sketch to test—it should alert and remove the button after
userStartAudio
succeeds