prevent crashes during completion of callbacks on disposed SoundFiles #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therewasaguy
approved these changes
Sep 11, 2018
| @@ -221,9 +221,11 @@ define(function (require) { | |||
| request.onload = function() { | |||
| if (request.status === 200) { | |||
| // on sucess loading file: | |||
| if (!self.panner) return; | |||
There was a problem hiding this comment.
This does the trick, but I wonder if there's a better way to check if the soundfile has been disposed. Or, better yet, to cancel any incomplete callbacks when the soundfile is disposed.
| * mySound = loadSound('assets/doorbell.mp3'); | ||
| * | ||
| * } | ||
| * function setup() { |
There was a problem hiding this comment.
👍 sorry for the trouble here!
therewasaguy
added a commit
that referenced
this pull request
Sep 11, 2018
therewasaguy
added a commit
to processing/p5.js
that referenced
this pull request
Sep 11, 2018
Thanks, @Spongman, for the fix here: processing/p5.js-sound#320
therewasaguy
added a commit
to processing/p5.js
that referenced
this pull request
Sep 11, 2018
* fix #3200 soundfile dispose error in reference test Thanks, @Spongman, for the fix here: processing/p5.js-sound#320 * patch convolverNode dispose processing/p5.js-sound#321
mrjoshida
pushed a commit
to mrjoshida/p5.js-sound
that referenced
this pull request
Sep 30, 2018
* 'master' of ssh://github.com/mrjoshida/p5.js-sound: rebuild lib dispose of ConvolverNode before resetting buffer (processing#321) rebuild lib with reference example fix processing#320 move loadSound call to preload prevent crashes during completion of callbacks on disposed SoundFiles 0.3.9 add soundfile.save example add `save()` and `getBlob()` methods to SoundFile. Move .wav conversion to helpers.js (processing#315) Added saveSoundToBlob() to soundRecorder.js Document properties of AudioIn update master limiter - sharp knee monosynth: remove unused _isOn monosynth: remove unused filter, patch velocity Missed this fragment during the renaming corrected formatting by replacing tabs with four spaces fixed issue: processing/p5.js-sound#297
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loadSoundcall topreload()in doc sample