Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added saveSoundToBlob() to soundRecorder.js #312

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

wahengchang
Copy link
Contributor

as my need is recording sound by microphone, then appending it to DOM for preview before it is downloaded. a temporary blob url is the choice.

@therewasaguy
Copy link
Member

thank you @wahengchang ! This will close https://github.com/processing/p5.js-sound/issues/257

@therewasaguy
Copy link
Member

as part of a related issue (https://github.com/processing/p5.js-sound/issues/314) we may want to move these away from the p5.prototype to the SoundFile

@therewasaguy therewasaguy merged commit feb4bd3 into processing:master Aug 7, 2018
@wahengchang
Copy link
Contributor Author

wahengchang commented Aug 9, 2018

@therewasaguy , when can I use the new version included this Pull-Request ?
I need it desperately

@therewasaguy
Copy link
Member

therewasaguy commented Aug 11, 2018

@wahengchang you can use it now by compiling p5 sound from source, and it will be included in the next release of p5.js, tho I'd like to move this (and saveSound) to p5.SoundFile / p5.SoundRecorder, before we make it part of the official API. Let me know if you have any thoughts on that, I'm about to take a look!

@therewasaguy
Copy link
Member

^ #315 would move saveBlob to SoundFile. I think that's the best home for this method?

@wahengchang
Copy link
Contributor Author

wahengchang commented Aug 12, 2018

I left a comment :)

@therewasaguy therewasaguy mentioned this pull request Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants