Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch monosynth velocity #305

Merged
merged 3 commits into from
Jul 2, 2018
Merged

patch monosynth velocity #305

merged 3 commits into from
Jul 2, 2018

Conversation

therewasaguy
Copy link
Member

This should fix https://github.com/processing/p5.js-sound/issues/301

  • Monosynth envelope ramps this.output.gain — the audio param — instead of this.output
  • Update master limiter knee and threshold so that it is better suited to prevent clipping. Specifying a sharp knee value makes a big difference, as does lowering the ratio slightly. We don't want to change the quality of sound unless it's nearly clipping.
  • remove some unused monosynth properties (_isOn and filter)

@therewasaguy therewasaguy requested review from JunShern and jvntf June 26, 2018 00:56
@JunShern
Copy link
Contributor

JunShern commented Jul 2, 2018

Awesome, this looks and sounds great! Should be good to merge. 👍

@therewasaguy therewasaguy merged commit 3e5c085 into processing:master Jul 2, 2018
@therewasaguy therewasaguy deleted the patch/monosynth-velocity branch July 2, 2018 16:00
@therewasaguy therewasaguy mentioned this pull request Sep 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunShern JunShern Awaiting requested review from JunShern

@jvntf jvntf Awaiting requested review from jvntf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inappropriate MonoSynth velocity range causes clipping/distortion
2 participants
@therewasaguy @JunShern