remove extraneous docs from overridden Noise methods.

[Spongman]

these docs in noise.js are duplicate docs for methods defined in the base class. i have removed them from the derived class because they are out of sync with the base definitions and are causing errors with the typescript definition build.

[therewasaguy]

thank you @Spongman!

[Spongman]

Thank you!

[JTBrunderley]

Hi @therewasaguy and @Spongman! I have run into this issue while using the p5.js 0.6.0 release from inside an angular5 js app. I understand I can resolve this issue manually by correcting the return type in the typescript definition file, so working with it locally is no issue. However, when I try to deploy my app to Heroku, it downloads the files through node during deployment and I don't have the ability to fix it there, so my deployments all fail. I see this was merged into master a few months ago, do you know when the version containing the fix will be released and available through node?

Thank you for the help and your work here!

[JTBrunderley]

For anyone looking for a work-around until until this fix is included in an official p5 release:

I created a windows batch file to manually correct the Noise amp method's return type in the p5.d.ts file.

Current Incorrect Line: amp(volume: number|object, rampTime?: number, timeFromNow?: number): void

Corrected Line: amp(volume: number|object, rampTime?: number, timeFromNow?: number): AudioParam

Inside file_fix.bat:

@echo off &setlocal
setlocal enabledelayedexpansion

set "search= amp(volume: number|object, rampTime?: number, timeFromNow?: number): void"
set "replace= amp(volume: number|object, rampTime?: number, timeFromNow?: number): AudioParam"
set "textfile=%~dp0node_modules\p5\lib\p5.d.ts"
set "newfile=%~dp0node_modules\p5\lib\p5_1.d.ts"
(for /f "delims=" %%i in (%textfile%) do (
set "line=%%i"
set "line=!line:%search%=%replace%!"
echo(!line!
))>"%newfile%"
del %textfile%
rename %newfile% p5.d.ts
endlocal

I run this batch file from node's package.json postinstall script. This way the p5.d.ts file is corrected directly after it is installed:

"postinstall": ".\\file_fix.bat"

If you are deploying to Heroku, then your script needs to be a bash script instead of a windows bat file.

Inside file_fix.sh:

SCRIPT=$(readlink -f "$0")
SCRIPTPATH=$(dirname "$SCRIPT")
sed -i 's/ amp(volume: number|object, rampTime?: number, timeFromNow?: number): void/ amp(volume: number|object, rampTime?: number, timeFromNow?: number): AudioParam/' $SCRIPTPATH/node_modules/p5/lib/p5.d.ts

This will fix the file before Heroku starts building the app. You will also need to give Heroku permission to execute the script. You can do that in the package.json postinstall like so:

"postinstall": "chmod a+x ./file_fix.sh && ./file_fix.sh && ng build --aot -prod"