update docs for Panner3d #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvntf
reviewed
Aug 22, 2017
src/panner3d.js
Outdated
| * Web Audio Spatial Panner Node</a> | ||
| * | ||
| * Properties include | ||
| * - panningModel: "equal power" or "HRTF" |
There was a problem hiding this comment.
I think this is ok, maybe we should just add links to the Web Audio docs for these properties? distanceModel and panningModel
There was a problem hiding this comment.
great idea, just added links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jvntf this fixes an issue when running
grunt yuito generate the docs in p5.js repoWarning: for Spatializer.positionZ() defined in lib/addons/p5.sound.js:8442, additional overloads should have no description ("<p>Getter and setter methods for orient coordinates</p>\n" !== "") Use --force to continue....but I'm not sure of the best way to get sub-properties of the p5.Panner3d.panner (distanceModel, panningModel) to display properly in our reference pages.