p5.Effect: Fix drywet function bug (#606)

processing · Apr 25, 2021 · ae8867a · ae8867a
1 parent 431d438
commit ae8867a
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 7 deletions.
diff --git a/lib/p5.sound.js b/lib/p5.sound.js
@@ -1,4 +1,4 @@
-/** [p5.sound]  Version: 1.0.0 - 2021-03-04 */ 
+/** [p5.sound]  Version: 1.0.0 - 2021-04-19 */ 
  /**
  *  <p>p5.sound extends p5 with <a href="http://caniuse.com/audio-api"
  *  target="_blank">Web Audio</a> functionality including audio input,
@@ -1180,6 +1180,7 @@ var CustomError = function CustomError(name, errorTrace, failedPath) {
 
 var moduleSources = [__webpack_require__(27)["default"], __webpack_require__(28)["default"], __webpack_require__(29)["default"]];
 var audioWorklet_ac = master.audiocontext;
+var initializedAudioWorklets = false;
 
 function loadAudioWorkletModules() {
   return Promise.all(moduleSources.map(function (moduleSrc) {
@@ -1192,6 +1193,8 @@ function loadAudioWorkletModules() {
 }
 
 p5.prototype.registerMethod('init', function () {
+  if (initializedAudioWorklets) return; 
+
   if (!this.preload && !window.preload) {
     this.preload = function () {};
   } 
@@ -1200,6 +1203,8 @@ p5.prototype.registerMethod('init', function () {
   this._incrementPreload();
 
   var onWorkletModulesLoad = function () {
+    initializedAudioWorklets = true;
+
     this._decrementPreload();
   }.bind(this);
 
@@ -6527,7 +6532,7 @@ function () {
 
   }, {
     key: "drywet",
-    value: function drywet() {
+    value: function drywet(fade) {
       if (typeof fade !== 'undefined') {
         this._drywet.fade.value = fade;
       }

diff --git a/lib/p5.sound.js.map b/lib/p5.sound.js.map
diff --git a/lib/p5.sound.min.js b/lib/p5.sound.min.js
diff --git a/lib/p5.sound.min.js.map b/lib/p5.sound.min.js.map
diff --git a/src/effect.js b/src/effect.js
@@ -101,7 +101,7 @@ class Effect {
    *  @for p5.Effect
    *  @param {Number} [fade] The desired drywet value (0 - 1.0)
    */
-  drywet() {
+  drywet(fade) {
     if (typeof fade !== 'undefined') {
       this._drywet.fade.value = fade;
     }