Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] Organize the snapshot & diff directories for bpmn rendering visual tests #944

Merged
merged 4 commits into from
Dec 14, 2020
Merged

[TEST] Organize the snapshot & diff directories for bpmn rendering visual tests #944

merged 4 commits into from
Dec 14, 2020

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Dec 9, 2020 •
edited
Loading

Covers #903

@csouchet csouchet added refactoring Code refactoring depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first labels Dec 9, 2020
@csouchet csouchet mentioned this pull request Dec 9, 2020
Merged
@csouchet csouchet removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Dec 14, 2020
aibcmars
aibcmars approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@aibcmars aibcmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csouchet csouchet merged commit 841c823 into master Dec 14, 2020
@csouchet csouchet deleted the 903-Organize_snapshot_diff_directories_for_BPMN_rendering_visual_tests branch December 14, 2020 09:21
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aibcmars aibcmars aibcmars approved these changes

@tbouffard tbouffard Awaiting requested review from tbouffard

Assignees
No one assigned
Labels
refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @aibcmars