Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] Refactor the computing of the snapshot & diff paths for the visual tests #939

Merged
merged 4 commits into from
Dec 14, 2020
Merged

[TEST] Refactor the computing of the snapshot & diff paths for the visual tests #939

merged 4 commits into from
Dec 14, 2020

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Dec 8, 2020 •
edited
Loading

Closes #903

@csouchet csouchet added WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft refactoring Code refactoring labels Dec 8, 2020
@csouchet csouchet force-pushed the 903-Organize_screenshots_of_visual_tests branch 4 times, most recently from f568ce4 to b9f85c4 Compare December 9, 2020 17:36
@csouchet csouchet added depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first and removed WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft labels Dec 9, 2020
@csouchet csouchet marked this pull request as ready for review December 10, 2020 09:53
@csouchet csouchet removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Dec 14, 2020
@csouchet csouchet force-pushed the 903-Organize_screenshots_of_visual_tests branch from b9f85c4 to 2f625aa Compare December 14, 2020 09:52
@csouchet csouchet changed the title [TEST] Organize the screenshots of the visual tests [TEST] Refactor the computing of the snapshot & diff paths for the visual tests Dec 14, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@csouchet csouchet merged commit 19a83c0 into master Dec 14, 2020
@csouchet csouchet deleted the 903-Organize_screenshots_of_visual_tests branch December 14, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

@aibcmars aibcmars Awaiting requested review from aibcmars

Assignees
No one assigned
Labels
refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TEST] Organize the screenshots of the visual tests
2 participants
@csouchet @tbouffard