Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INFRA] update rollup livereload with postcss #931

Merged
merged 7 commits into from
Dec 9, 2020
Merged

[INFRA] update rollup livereload with postcss #931

merged 7 commits into from
Dec 9, 2020

Conversation

aibcmars
Copy link
Contributor

@aibcmars aibcmars commented Dec 4, 2020 •
edited by tbouffard
Loading

closes #918

@aibcmars aibcmars force-pushed the 918-update_rollup_livereload_wit_postcss branch from 1e0a75b to c8b475d Compare December 8, 2020 08:59
@aibcmars aibcmars marked this pull request as ready for review December 8, 2020 08:59
@csouchet
Copy link
Member

csouchet commented Dec 8, 2020

What is that ?

image

@aibcmars
Copy link
Contributor Author

aibcmars commented Dec 8, 2020 •
edited by tbouffard
Loading

it is just to be able to test livereload locally (I've tested on Windows only)

  1. Start project npm run watch
  2. Check if changes are reflected on the page - play with files:

MacOS

  • src/static/css/style.css
  • src/index.html

Ubuntu

  • src/static/css/style.css. This takes a few seconds to be considered by the livereload in the page, but it is working
  • src/index.html

tbouffard
tbouffard reviewed Dec 8, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we have at least a pending question to answer and temp code to remove.
Otherwise, everything is fine for me

I have seen a nice trick to integrate the css watch as part of the rollup build 😄

postcss.config.js Outdated Show resolved Hide resolved
@aibcmars aibcmars requested a review from tbouffard December 9, 2020 10:39
tbouffard
tbouffard approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Removing the generated css file work for both build, watch and demo

@aibcmars aibcmars force-pushed the 918-update_rollup_livereload_wit_postcss branch from 3b95c34 to eea495d Compare December 9, 2020 15:27
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aibcmars aibcmars merged commit 4e23a92 into master Dec 9, 2020
@aibcmars aibcmars deleted the 918-update_rollup_livereload_wit_postcss branch December 9, 2020 15:50
@tbouffard tbouffard mentioned this pull request Dec 11, 2020
Closed
@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Enable postcss processing for tailwind in livereload mode
3 participants
@aibcmars @csouchet @tbouffard