Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] clarify contributors and users documentation folders #904

Merged
merged 9 commits into from
Nov 24, 2020

Conversation

tbouffard
Copy link
Member

Use folder names we agreed on in #892 (comment)

I did my best to search various documentation paths to ensure everything has been updated, but please recheck when doing the review

@tbouffard tbouffard added the documentation Improvements or additions to documentation label Nov 23, 2020
@tbouffard tbouffard requested review from a team, csouchet and aibcmars and removed request for a team November 23, 2020 16:10
Copy link
Member

@csouchet csouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing:

  • Update the link of the image in the main README
  • Update the link onSome BPMN icons used by `bpmn-visualization` are derived from existing projects. See the [BPMN Support page](docs/bpmn-support.adoc) in the main README

@csouchet
Copy link
Member

ℹ️ Don't forget to update the links in the REAME of the examples 😉

@tbouffard
Copy link
Member Author

@csouchet

Copy link
Contributor

@aibcmars aibcmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbouffard I have added a small suggestion - I leave it up to you to integrate it

PR LGTM 👍

Co-authored-by: Marcin Michniewicz <[email protected]>
@tbouffard tbouffard merged commit 4e60691 into master Nov 24, 2020
@tbouffard tbouffard deleted the doc/clarify_users_and_contributors_documentations branch November 24, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants