Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEMO] Start reworking the demo page design #896

Merged
merged 14 commits into from
Nov 30, 2020
Merged

[DEMO] Start reworking the demo page design #896

merged 14 commits into from
Nov 30, 2020

Conversation

aibcmars
Copy link
Contributor

@aibcmars aibcmars commented Nov 20, 2020 •
edited by tbouffard
Loading

Rework the demo page with tailwindcss basic design.

Covers #879

@aibcmars
Copy link
Contributor Author

For now it looks like this
(in draft as it's POC and not yet responsive)

2020-11-20_17h38_38

@aibcmars aibcmars force-pushed the 879-rework_demo_page branch 2 times, most recently from 57cc2b1 to 38381d8 Compare November 24, 2020 17:39
@aibcmars
Copy link
Contributor Author

image

@aibcmars
Copy link
Contributor Author

aibcmars commented Nov 25, 2020 •
edited
Loading

Demo on mobile phone
ezgif com-gif-maker

@aibcmars aibcmars marked this pull request as ready for review November 25, 2020 15:42
@aibcmars aibcmars changed the title [DEMO] poc with tailwindcss [DEMO] New demo page - with tailwindcss basic design Nov 25, 2020
@aibcmars aibcmars added the example This issue or pull request is related to the lib demo or examples label Nov 25, 2020
@aibcmars aibcmars mentioned this pull request Nov 25, 2020
Closed
3 tasks
@tbouffard tbouffard changed the title [DEMO] New demo page - with tailwindcss basic design [DEMO] Start reworking the demo page design Nov 26, 2020
@tbouffard
Copy link
Member

tbouffard commented Nov 26, 2020 •
edited
Loading

Some rendering issues on Firefox 83.0 on Ubuntu 18.04, compared to Chrome/Chromium 87.0

Fit margin: display and impossible to enter value or to use the increase/decrease scrolls

Firefox Chrome
image image

Drag&Drop: the Open BPMN Diagram text in not displayed in the overlay
This is displayed in the test pages but the text is at the bottom on Firefox whereas it is center on Chrome
Test pages: http://localhost:10001/rendering-diagram.html?showControlsPanel=true and http://localhost:10001/non-regression.html?

tbouffard
tbouffard reviewed Nov 26, 2020
View reviewed changes
src/index.html Show resolved Hide resolved
src/demo/component/DropFileUserInterface.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
src/static/js/demo.js Show resolved Hide resolved
src/static/js/demo.js Show resolved Hide resolved
tbouffard
tbouffard reviewed Nov 30, 2020
View reviewed changes
src/index.html Outdated Show resolved Hide resolved
@tbouffard
Copy link
Member

tbouffard commented Nov 30, 2020 •
edited
Loading

✔️ now working on Firefox thanks to a8c6e39

  • drag&drop
  • fit configuration display

@aibcmars aibcmars force-pushed the 879-rework_demo_page branch from 84d8e4a to a8b8b79 Compare November 30, 2020 10:17
tbouffard
tbouffard approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job!

@aibcmars aibcmars mentioned this pull request Nov 30, 2020
Closed
aibcmars and others added 13 commits November 30, 2020 13:14
@aibcmars
[DEMO] poc with tailwindcss
ebef3ce
@aibcmars
[FEAT] rework demo page
5b9cb38 
- tailwind.css
- purged, minified css
@aibcmars
[FEAT] rework demo page
681a747 
- tailwind.css
- purged, minified css
@aibcmars
[FEAT] rework demo page
d2db73c 
- render when fit margin changes
@aibcmars
[FEAT] rework demo page
0cde5d2 
- add zoom settings
- prevent page zooming while zooming out of bpmn-container
@aibcmars
[FEAT] rework demo page
69558a4 
- fixed height for diagram container
- adjust drop-container for the new demo
- controls width
@aibcmars
[FEAT] rework demo page
15b0dc8 
- lint fix
- sonarcloud fix
@aibcmars
[FEAT] rework demo page
68b626a 
- drop area size
@aibcmars
[FEAT] rework demo page
4231028 
- drop area size fix
@aibcmars
[FEAT] rework demo page
09791cc 
- navigation title looks more like one in examples
@aibcmars
[FEAT] rework demo page
fb005df 
- fix for firefox and some feedback integrated
@aibcmars
[FEAT] rework demo page
d88ea39 
- document tailwind
- replace outer div padding with fit margin
@tbouffard @aibcmars
Rename the page about the css for the demo
0604fca
@tbouffard @aibcmars
index.html: remove 'graph' from comment and use 'bpmn-container' instead
fdc488e 
Use something more related to our domain to be consistent with the rest of the
documentation, code and examples.
@aibcmars aibcmars force-pushed the 879-rework_demo_page branch from 0ce882d to fdc488e Compare November 30, 2020 12:16
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aibcmars aibcmars merged commit e5197ea into master Nov 30, 2020
@aibcmars aibcmars deleted the 879-rework_demo_page branch November 30, 2020 12:41
@tbouffard tbouffard mentioned this pull request Jan 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
example This issue or pull request is related to the lib demo or examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aibcmars @tbouffard