[REFACTOR] Update the FitType API #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplify fit type conversion in js scripts & string variables
csouchet
force-pushed
the
861-Refactor_fit_type_value
branch
from
2f4bb06 to
2653c7b
Compare
tbouffard
approved these changes
Nov 23, 2020
| @@ -26,7 +26,7 @@ let loadOptions: LoadOptions = {}; | |||
| export function updateLoadOptions(fitOptions: FitOptions): void { | |||
| log('Updating load options', fitOptions); | |||
| loadOptions.fit = fitOptions; | |||
| log('Load options updated!', loadOptions); | |||
| log('Load options updated!', stringify(loadOptions)); | |||
aibcmars
pushed a commit
that referenced
this pull request
Nov 24, 2020
- Replace number value of the fitType by string - Simplify fit type conversion in js scripts & string variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers #861