Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] update bpmn div id in test pages #893

Merged
merged 9 commits into from
Nov 19, 2020
Merged

[REFACTOR] update bpmn div id in test pages #893

merged 9 commits into from
Nov 19, 2020

Conversation

tbouffard
Copy link
Member

covers #866

@tbouffard tbouffard added the refactoring Code refactoring label Nov 18, 2020
@tbouffard tbouffard mentioned this pull request Nov 18, 2020
Closed
5 tasks
@tbouffard tbouffard marked this pull request as ready for review November 18, 2020 15:38
@tbouffard tbouffard requested review from a team, csouchet and aibcmars and removed request for a team November 18, 2020 15:38
csouchet
csouchet requested changes Nov 18, 2020
View reviewed changes
Copy link
Member

@csouchet csouchet left a comment •
edited by tbouffard
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is again some 'viewport' in the doc/code.
We need to update:

  • the TSDoc in enum FitType
  • lib-integration-iife.html

@tbouffard tbouffard requested a review from csouchet November 18, 2020 16:57
@tbouffard tbouffard merged commit cd8f5b7 into master Nov 19, 2020
@tbouffard tbouffard deleted the 866-update_bpmn_div_id_in_test_pages branch November 19, 2020 09:18
@tbouffard tbouffard mentioned this pull request Nov 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csouchet csouchet csouchet approved these changes

@aibcmars aibcmars Awaiting requested review from aibcmars

Assignees
No one assigned
Labels
refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbouffard @csouchet