Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Merge html pages used in visual tests #891

Merged
merged 7 commits into from
Nov 18, 2020
Merged

[REFACTOR] Merge html pages used in visual tests #891

merged 7 commits into from
Nov 18, 2020

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Nov 17, 2020 •
edited by tbouffard
Loading

covers #866
covers #879

@csouchet csouchet added the refactoring Code refactoring label Nov 17, 2020
@csouchet csouchet force-pushed the refactor/merge_navigation_and_diagram_rendering_pages branch from 7d3a870 to 7557139 Compare November 17, 2020 16:48
@csouchet csouchet force-pushed the refactor/merge_navigation_and_diagram_rendering_pages branch from 7557139 to 52261c2 Compare November 17, 2020 17:01
@csouchet csouchet marked this pull request as ready for review November 17, 2020 17:09
@tbouffard tbouffard changed the title [REFACTOR] Merge navigation-diagram page on rendering-diagram page for visual tests [REFACTOR] Merge html pages used in visual tests Nov 18, 2020
@csouchet csouchet requested a review from tbouffard November 18, 2020 10:59
tbouffard
tbouffard approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The control panel is only visible for human when passing showControlsPanel=true in the URL, but this looks ok for now. If this is annoying, we will display it by default later.

@tbouffard tbouffard mentioned this pull request Nov 18, 2020
Closed
3 tasks
aibcmars
aibcmars approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@aibcmars aibcmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@csouchet csouchet merged commit 16fd3db into master Nov 18, 2020
@csouchet csouchet deleted the refactor/merge_navigation_and_diagram_rendering_pages branch November 18, 2020 13:07
@tbouffard tbouffard mentioned this pull request Nov 18, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aibcmars aibcmars aibcmars approved these changes

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csouchet @tbouffard @aibcmars