Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Prepare the demo page for the fit after load #882

Merged
merged 2 commits into from
Nov 13, 2020
Merged

[REFACTOR] Prepare the demo page for the fit after load #882

merged 2 commits into from
Nov 13, 2020

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Nov 10, 2020 •
edited by tbouffard
Loading

  • introduce functions to configure fit on load options from url parameters (all pages)
  • introduce functions to configure demo elements (buttons and inputs)
  • rename url parameter from fitType to fitTypeOnLoad
  • debug: always log 'load options' after loading the diagram (previously, this was only done at configuration time)

Covers #738

@csouchet csouchet added the refactoring Code refactoring label Nov 10, 2020
@csouchet csouchet mentioned this pull request Nov 10, 2020
Merged
@csouchet csouchet force-pushed the refactor/prepare_demo_page_for_fit_after_load branch from 203f179 to 1c70211 Compare November 10, 2020 20:10
tbouffard
tbouffard approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbouffard tbouffard merged commit 2840f31 into master Nov 13, 2020
@tbouffard tbouffard deleted the refactor/prepare_demo_page_for_fit_after_load branch November 13, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

@aibcmars aibcmars Awaiting requested review from aibcmars

Assignees
No one assigned
Labels
refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @tbouffard