Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Change the name of the visual tests for the fit on load #875

Merged
merged 1 commit into from
Nov 9, 2020
Merged

[REFACTOR] Change the name of the visual tests for the fit on load #875

merged 1 commit into from
Nov 9, 2020

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Nov 9, 2020

Covers #738

@csouchet csouchet added the refactoring Code refactoring label Nov 9, 2020
@csouchet csouchet mentioned this pull request Nov 9, 2020
Merged
tbouffard
tbouffard approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csouchet csouchet marked this pull request as ready for review November 9, 2020 16:18
@csouchet csouchet merged commit edf7106 into master Nov 9, 2020
@csouchet csouchet deleted the refactor/load_visual_tests branch November 9, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @tbouffard