Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INFRA] Tests performance measurement #856

Merged
merged 26 commits into from
Nov 5, 2020
Merged

[INFRA] Tests performance measurement #856

merged 26 commits into from
Nov 5, 2020

Conversation

aibcmars
Copy link
Contributor

@aibcmars aibcmars commented Nov 3, 2020 •
edited
Loading

it lacks one more thing but wanted to already share it and get the feedback

  • add in index.html conditional data loading per platform - for now fixed windows is used)

@aibcmars aibcmars added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Nov 3, 2020
@aibcmars aibcmars added this to the 0.7.0 milestone Nov 3, 2020
@aibcmars
Copy link
Contributor Author

aibcmars commented Nov 3, 2020

image

@aibcmars aibcmars force-pushed the tests-performance_measurement branch from b284303 to 37d27c0 Compare November 3, 2020 08:59
@aibcmars aibcmars force-pushed the tests-performance_measurement branch from 3ab0af4 to 212477b Compare November 4, 2020 12:06
tbouffard
tbouffard reviewed Nov 4, 2020
View reviewed changes
.eslintignore Outdated Show resolved Hide resolved
test/e2e/performance/bpmn.load.performance.test.ts Outdated Show resolved Hide resolved
test/e2e/performance/index.html Show resolved Hide resolved
@aibcmars aibcmars force-pushed the tests-performance_measurement branch from 36cb700 to 541cdd1 Compare November 4, 2020 16:33
tbouffard
tbouffard reviewed Nov 4, 2020
View reviewed changes
docs/development/testing.md Show resolved Hide resolved
docs/development/testing.md Outdated Show resolved Hide resolved
csouchet
csouchet requested changes Nov 5, 2020
View reviewed changes
Copy link
Member

@csouchet csouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the doc, and it doesn't work on MacOs 😢

@tbouffard tbouffard mentioned this pull request Nov 5, 2020
Open
8 tasks
csouchet
csouchet approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@csouchet csouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's work now. Juste some typo for the doc

tbouffard
tbouffard reviewed Nov 5, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't forget @csouchet suggestions about documentation improvements 😄

@aibcmars aibcmars merged commit 8189660 into master Nov 5, 2020
@aibcmars aibcmars deleted the tests-performance_measurement branch November 5, 2020 17:47
@tbouffard tbouffard mentioned this pull request Nov 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard left review comments

@csouchet csouchet csouchet approved these changes

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aibcmars @csouchet @tbouffard